erikvanoosten / metrics-scala

The scala API for Dropwizard's Metrics.
Apache License 2.0
427 stars 62 forks source link

Weird version number for 4.3.3 #556

Closed mccartney closed 2 weeks ago

mccartney commented 2 weeks ago

After 4.3.2 the next version which got released is:

4.3.3+0-68d2004e+20241007-1150/

Not fully sure if this is intended. Is it some new versioning schema applied or some mistake creeping in?

See e.g. https://repo1.maven.org/maven2/nl/grons/metrics4-scala_2.12/

image
mccartney commented 2 weeks ago

I fail to see any commit in the recent ones (since 4.3.2) which would directly call for this. So I guess this is an effect of some upstream dependency upgrade. sbt-sonatype?

erikvanoosten commented 2 weeks ago

It must have been my error while doing the release. I should really automate it...

erikvanoosten commented 2 weeks ago

Yes, I see now. I tagged 1 commit to early 😞

Correction: I released one commit after the tag.

erikvanoosten commented 2 weeks ago

I have now released from the commit tagged 4.3.3, meaning that 4.3.3 will soon be properly on maven central.

Thanks for the report @mccartney !