Fix issue with air quality rendering a white background.

[shyce]

This pull request fixes the default and bubble theme so that including air works properly by default.

• air_color.sh now exports TMUX_POWERLINE_SEG_AIR_COLOR
• Themes now source air_color.sh. I think there should be a standard interface for segments to provide suggested colors in the future but this works fine for now.
• Fixed up some extra spaces after comments.

[xx4h]

Hi @shyce, thanks for pointing that out and already providing a solution!

The way i see it, air_color.sh should not be a segment at all. Overriding the color for a specific symbol of a segment should be done directly in the segment. Something like we did here: https://github.com/erikw/tmux-powerline/blob/fd480c2d6ae5e24a18589c4ef8e3685bc576e186/segments/vcs_branch.sh#L9 and then use it like this: https://github.com/erikw/tmux-powerline/blob/fd480c2d6ae5e24a18589c4ef8e3685bc576e186/segments/vcs_branch.sh#L68

What do you think? Do you want to go for this refactor?

[shyce]

Yeah let me take a look at this tonight after a bit of a break from the pc. I didn't like it either, just didn't want to commit a big change as a new contributor. Thanks for the feedback!

[xx4h]

Yeah let me take a look at this tonight after a bit of a break from the pc. I didn't like it either, just didn't want to commit a big change as a new contributor. Thanks for the feedback!

Cool, appreciate it! Let me know if you have any questions.

[shyce]

I gave this a shot last night and it looks like it will need a bit more work. No modules are using #[bg=] currently because it doesn't color the powerline symbols as well, since it allows you to have multiple background colors in one echo. I'm still thinking about the best way to do this while adhering to the previous theme api.

I didn't want to change the way #[bg=] works because it might break peoples custom themes.

[xx4h]

Oh, i guess i got i wrong yesterday. So it is not about the color for the symbol, it's about the color of the whole segment, right? And based on the air-quality the color of the segment should change?

[shyce]

Yeah the air quality index changes the whole segment color based on the quality of the air I guess. I tried the echo approach instead of sourcing and for some reason, the output would not concat to the string. No idea why.

[shyce]

I just tried again, and I guess I made a typo because it did work this time. Let me update it.

[shyce]

Stand by, I guess my editor tab stops do not match the project.

[shyce]

That's much cleaner, thanks. I'll try again at my dynamic approach that lets each segment setup their own colors in a later PR.