search

erikwett / DevTool

Developer Tool extension for Qlik Sense
MIT License
33 stars 6 forks source link

Port from extension to browser snap-in #1

Closed mindspank closed 5 years ago

mindspank commented 9 years ago

What do you think of porting this into a browser extension for Chrome/Firefox? It would decouple it from having to be an extension so you could potentially also use it for apps that has been published on the server.

I'd be happy to take a stab at it

mindspank commented 9 years ago

Clarification around "apps that has been published on the server." where you don't have edit access to add the extension that is :)

erikwett commented 9 years ago

Sounds like a good idea, go ahead! I would love to cooperate but have no experience in chrome extensions. Another benefit would be that it could work in mashup scenarios.

mindspank commented 9 years ago

So I was playing around with it, do you have tips on how to check if qlik is loaded on the page? I could check for qvangularGlobal on the window object but if someone manually bootstraps our angular module on to the page...

Hmm, maybe that's an extreme edge-case we could live with :)

erikwett commented 9 years ago

No, I dont know of any better method, and I think it will be there in all scenarios. But if you've got qlik in an iframe you would need to check that too, guess you've thought of that..

On Fri, Sep 11, 2015 at 12:57 AM, Alexander Karlsson < notifications@github.com> wrote:

So I was playing around with it, do you have tips on how to check if qlik is loaded on the page? I could check for qvangularGlobal on the window object but if someone manually bootstraps our angular module on to the page...

Hmm, maybe that's an extreme edge-case we could live with :)

— Reply to this email directly or view it on GitHub https://github.com/erikwett/DevTool/issues/1#issuecomment-139405539.

erikwett commented 5 years ago

Fixed! Check here: https://chrome.google.com/webstore/detail/add-sense/bbiljflfafkaejgdebbnmcohpidgkejj