Prework feedback

[buihdk]

Hey Erik! Thanks for submitting the pre-work for the CoderSchool Web Design course :) Here is some feedback after going over your prework assignments:

• Assignment 1: Good job in wrapping all the HTML content using HTML elements. Some people left out some of the raw content and that is considered to be bad practice. I would use h2 instead of h3 for the second largest headings but then you can restyle the headings in CSS. Some minor mistakes such as <sup> "Kasparov1" and "began a five-game match" but these are easy fixes.
• Assignment 2: The animal card looks slick! It looks even better than the prototype. You seem to have done some css styling before. For the list, you can use list-style-type: none; padding-left: unset; to make it looks similar to the prototype. Also, congratulate on making an attempt on using Bootstrap, we will actually go over this framework in details in Week 2. I would avoid restyling the .card class because this is a bootstrap card (if you have more than one card in multiple pages, your styling here will apply to all the cards). You can make another class called .animal-card and write your css there. Still not sure why you are using position: absolute and transform here. Advanced positioning like absolute should be used with caution because it's unresponsive. One way to fix this is removing position: absolute; top: 50%; left: 50%; transform: translate(-50%,-50%); in your .card css and set this to your .card in html: <div class="card col-8 mx-auto">. Hope this helps!

Your work looks pretty good overall! And I hope to see you in the class next Tuesday. If you have any further questions, let me know.

[erikyoung]

Hey Khoa,

I was sort of curious how much JS we'd be working on in the course. I'm really quite keen to see where I can improve with this as well. If it's ok, I already have a working Rails portfolio site that I'd like to build on and improve as part of the course. I hope that's ok.

On 23 July 2018 at 14:36, Khoa Bui notifications@github.com wrote:

Hey Erik! Thanks for submitting the pre-work for the CoderSchool Web Design course :) Here is some feedback after going over your prework assignments:

• Assignment 1: Good job in wrapping all the HTML content using HTML elements. Some people left out some of the raw content and that is considered to be bad practice. I would use h2 instead of h3 for the second largest headings but then you can restyle the headings in CSS. Some minor mistakes such as ^{"Kasparov1" and "began a five-game match" but these are easy fixes.}
• Assignment 2: The animal card looks slick! It looks even better than the prototype. You seem to have done some css styling before. For the list, you can use list-style-type: none; padding-left: unset; to make it looks similar to the prototype. Also, congratulate on making an attempt on using Bootstrap, we will actually go over this framework in details in Week 2. I would avoid restyling the .card class because this is a bootstrap card (if you have more than one card in multiple pages, your styling here will apply to all the cards). You can make another class called .animal-card and write your css there. Still not sure why you are using position: absolute and transform here. Advanced positioning like absolute should be used with caution because it's unresponsive. One way to fix this is removing position: absolute; top: 50%; left: 50%; transform: translate(-50%,-50%); in your .card css and set this to your .card in html:
  . Hope this helps!

Your work looks pretty good overall! And I hope to see you in the class next Tuesday. If you have any further questions, let me know.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/erikyoung/coderschool-webdesign/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ATGiH8uGnoYQqpLBldIAhbwzewGYxYLLks5uJXzrgaJpZM4VagVP .

--

Kind regards

Erik Young MS, MA, Grad Cert

Centre of Communication & Design (CoCD)

RMIT University - Vietnam 702 Nguyen Van Linh Boulevard, Tan Phong Ward, District 7, Ho Chi Minh City, Vietnam

E: erik.young@rmit.edu.vn sarah.gumbley@rmit.edu.vn

T: +84 8 3776 1300 ext. 2243 F: +84 8 3776 1399

W: www.rmit.edu.vn

M: +84 (0)121 554 8964

[buihdk]

Hey Erik,

Sorry for the super late reply. The JS week will be like an introduction to JS and OOP where the students will learn about variables, control flow, functions, and objects. You will build 2 projects:

• A chat app with a chatbot. Example: http://www.winniephan.com/projects/URI-chatapp/index.html
• A Web app using a simple API. Ghibli API: https://ghibliapi.herokuapp.com/. Final product: https://taniarascia.github.io/sandbox/ghibli/

You can integrate the portfolio that you build by the end of this class into your Rails portfolio. I can help you accomplish that.