search

erikzaadi / GithubSharp

No longer maintained, please use https://github.com/octokit/octokit.net
96 stars 47 forks source link

Some changes to GitSharpHub #4

Closed DinisCruz closed 13 years ago

DinisCruz commented 13 years ago

HI , I added support to GitHubSharp to the O2 Platform (http://o2platform.com) and had to make these couple changes to make the API work.

I also added a number of extension methods which make it simpler to consume, which you can see here: http://code.google.com/p/o2platform/source/browse/trunk/O2_Scripts/3rdParty_Tools/GitHub/API_GitHub_Issues.cs

erikzaadi commented 13 years ago

Thanks Dinis!

Why did you add the compiled dll files?

DinisCruz commented 13 years ago

Because I want to consume directly those dlls from O2http://o2platform.com without having to download and compile the sources

In O2's scripting environment I can just use a //O2Ref:{dll} reference and it will fetch the dll and add it to the script's referenced dlls.

If you want, you don't have to merge those dlls into the main master branch. In fact, when I did my pull I was trying NOT to include that patch/commit, but there didn't seem to be a way to do it on the github gui (I'm still new to github)

On the changes, do you still think that that username field is needed?

Dinis

http://o2platform.com

On Mon, Mar 21, 2011 at 8:17 AM, erikzaadi < reply@reply.github.com>wrote:

Thanks Dinis!

Why did you add the compiled dll files?

Reply to this email directly or view it on GitHub: https://github.com/erikzaadi/GithubSharp/pull/4#issuecomment-897539

erikzaadi commented 13 years ago

Right.. Well I won't include the compiled dlls in the master branch, if needed, we can always provide a zip file with the binaries in the downloads section..

As for the userfield, if the correct data is fetched, then it doesn't matter..

Thanks for the contribution, I'm pulling (except for the bin)!