erikzenker / hsm

Finite state machine library based on the boost hana meta programming library. It follows the principles of the boost msm and boost sml libraries, but tries to reduce own complex meta programming code to a minimum.
MIT License
187 stars 18 forks source link

[BUG] MSVC_RUNTIME_LIBRARY in tests #150

Closed friendlyanon closed 3 years ago

friendlyanon commented 3 years ago

Describe the bug

To Reproduce -

Expected behavior

Additional context Is this property even necessary?
The VS generator for CMake already uses /MDd for Debug configuration and /MD for everything else.
Is statically linking the CRT for the tests important?

erikzenker commented 3 years ago

I am not an expert for msvc. I just added MSVC_RUNTIME_LIBRARY to satisfy the compiler and get CI. If we just need to set minimum cmake version to 3.15 that would be okay for me.

friendlyanon commented 3 years ago

I just built and ran the tests without the property, I think it can be safely dropped.