search

erikzimmermann / TradeSystem

A highly customizable, free and open-source Minecraft plugin for trading between players.
https://www.spigotmc.org/resources/trade-system-custom-layouts.58434/
MIT License
82 stars 48 forks source link

TradeProxy server error when adding items to trade UI #380

Closed Dakotaa closed 2 years ago

Dakotaa commented 2 years ago

Describe the bug When using TradeProxy and trading with a player on another server, putting an item into the trade UI will cause this error to pop up on the server that the other player is on.

The item does not show in the trade UI for the other player, and neither player receives any items upon trade completion.

The money and ready UI elements still update correctly cross-server.

To Reproduce Steps to reproduce the behavior:

  1. Have TradeProxy running with TradeSystem running on Server A and Server B.
  2. Have player on Server A send a trade request to player on Server B.
  3. Once player on Server B accepts request, have player on Server A add item to trade window.
  4. Player on Server B does not see item in trade window, and error is thrown on Server B.

Additional context The discord conversation about this, for more info.

Discord contact: Dakota#8551

erikzimmermann commented 2 years ago

Should also affect #377