search

erikzimmermann / TradeSystem

A highly customizable, free and open-source Minecraft plugin for trading between players.
https://www.spigotmc.org/resources/trade-system-custom-layouts.58434/
MIT License
80 stars 48 forks source link

Better bedrock input #498

Closed masmc05 closed 1 year ago

masmc05 commented 1 year ago

Fix https://github.com/erikzimmermann/TradeSystem/issues/492 Fix https://github.com/erikzimmermann/TradeSystem/issues/496 Maybe a fix for https://github.com/erikzimmermann/TradeSystem/issues/467 since it also could be related to bedrock

This allows bedrock players to have an alternative input that will allow them to enter the sum to trade, since the sign and anvil are a bit broken on bedrock

erikzimmermann commented 1 year ago

First of all, thank you for your work! Do you maybe have an image of how the input looks like? Is it an actuall slider?

ezriharmusial commented 1 year ago

I have also noticed that i can not trade with Bedrock players. Deal gets cancelled after both partys agree to the trade. Is this a Correct observation?

masmc05 commented 1 year ago

First of all, thank you for your work! Do you maybe have an image of how the input looks like? Is it an actuall slider?

image image image

Here are some screenshots

masmc05 commented 1 year ago

I have also noticed that i can not trade with Bedrock players. Deal gets cancelled after both partys agree to the trade. Is this a Correct observation?

With this pr you can

masmc05 commented 1 year ago

You can read more about them on https://geysermc.ru/wiki/floodgate/forms-and-cumulus

erikzimmermann commented 1 year ago

I have also noticed that i can not trade with Bedrock players. Deal gets cancelled after both partys agree to the trade. Is this a Correct observation?

Well, this is caused by the countdown I guess. Updating GUI titles seem to crash the inventory on bedrock clients... Will be fixed in the next update tho.

erikzimmermann commented 1 year ago

@masmc05 Well I've got a test server running with Geyser and floodgate installed but it does not want to work.

I've tried the Geyser API too and have following: image

So floodgate does not know anything about the Bedrock player and using Geyser I get LinkageErrors due to the dependency management in their libraries...

Any ideas?

masmc05 commented 1 year ago

@masmc05 Well I've got a test server running with Geyser and floodgate installed but it does not want to work.

I've tried the Geyser API too and have following: image

So floodgate does not know anything about the Bedrock player and using Geyser I get LinkageErrors due to the dependency management in their libraries...

Any ideas?

do you use floodgate auth mode?

erikzimmermann commented 1 year ago

No, gonna change it rq.

Please write me on Discord (tag: codingair)

FrancescoJacovo commented 9 months ago

guys i'm still having problems between java and bedrock trades. In the last repetition before the trade completitions it breaks as "trade cancelled"

SkyDude0 commented 3 weeks ago

same