erikzimmermann / TradeSystem

A highly customizable, free and open-source Minecraft plugin for trading between players.
https://www.spigotmc.org/resources/trade-system-custom-layouts.58434/
MIT License
76 stars 48 forks source link

NaN + Hacked Client Dupe #508

Closed KhrysAK47 closed 5 months ago

KhrysAK47 commented 5 months ago

Describe the bug A dupe glitch that allows players to get any amount of traded items.

To Reproduce Steps to reproduce the behavior: 1) Enable Vault trade layout 2) Initiate a trade with someone 3) Set the currency amount to 'NaN'. 4) Use a client with dual trade like Wurst and since NaN breaks trade gui, simply trade what you want.

Expected behavior It should not happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Running latest version of TradeSystem to the date of this report and Paper 1.20.4.

Discord contact: khrystyian

KhrysAK47 commented 5 months ago

Bump

KhrysAK47 commented 5 months ago

Fixing the ability to put NaN in custom currency should fix this.