search

erikzimmermann / TradeSystem

A highly customizable, free and open-source Minecraft plugin for trading between players.
https://www.spigotmc.org/resources/trade-system-custom-layouts.58434/
MIT License
82 stars 48 forks source link

[DUPE] clone item trade #514

Closed eskabal closed 2 months ago

eskabal commented 9 months ago

found a critical bug in the plugin that allows item duplication during player trades. This issue occurs when a player is engaged in a trade and decides to throw out an item while the trade is ongoing.

Under normal circumstances, items discarded during a trade should not be duplicated. However, I've observed that this particular plugin has a vulnerability that enables the duplication of items. When a player attempts to discard an item during an ongoing trade, it unintentionally triggers the duplication, resulting in an incorrect quantity of the respective item in the game's economy.

Coloboks commented 9 months ago

Can you send a video?

erikzimmermann commented 2 months ago

Outdated, please re-open if this still occurs.