This PR fixes the false positives that are coming up with some AVs on Virus Total.
It seems like that many clone operations in a row is maybe suspicious from a byte-code perspective.
I remove the .clone() calls and moved them to the IconData class and the detections are gone.
Is the clone even needed here, are the ItemStacks modified somewhere else that has side-effects? If not, you can also remove that.
This PR fixes the false positives that are coming up with some AVs on Virus Total. It seems like that many clone operations in a row is maybe suspicious from a byte-code perspective.
I remove the .clone() calls and moved them to the IconData class and the detections are gone.
Is the clone even needed here, are the ItemStacks modified somewhere else that has side-effects? If not, you can also remove that.
New VirusTotal with the PR in place: https://www.virustotal.com/gui/file/9599dc52e762451752b5292ee6a931f0eec0f67365fa3920987758aba33b6059
In comparison to the latest hotfix version: https://www.virustotal.com/gui/file-analysis/NzNkZjA2YjFhNTgwMzY3NjY4N2I0NzE3MmM1ZDkxMWY6MTcxNzA4MDkxNw==