erikzimmermann / WarpSystem-IssueTracker

https://www.spigotmc.org/resources/warps-portals-and-more-warp-teleport-system-1-8-1-16.29595/
5 stars 1 forks source link

[PlayerSkins.yml] Tick spike when new players join #766

Closed Parthodys closed 8 months ago

Parthodys commented 9 months ago

Describe the bug Tick spike when new players join the server, possibly related to a large PlayerSkins.yml file.

To Reproduce

  1. Have a large PlayerSkins.yml file (larger the laggier).
  2. Have a new player join the server.
  3. New player is added to the file, creating a tick drop when the file is opened/saved.

Expected behavior Ticks should remain stable.

Screenshots image

Additional context This could be related to the PlayerSkins.yml file, which keeps saving each player's skin. After having tens of thousands of accounts visit, the file starts to get heavier to open/save each time a new player joins.

I would suggest not saving skins in this way if possible, or perhaps at least an option to disable it. While a database file would be more efficient with large amounts of accounts, it seems a bit excessive to use for a minor feature. Perhaps a way to clear inactive accounts would be another option.

Discord contact: Graddod