search

eringerli / esp32-aog

Software to controll the tractor from AgOpenGPS
MIT License
28 stars 9 forks source link

Code review before pull request #8

Open benreu opened 3 years ago

benreu commented 3 years ago

In my fork https://github.com/benreu/esp32-aog, I have made substantial changes including:

  1. autoreconnect if WiFi gets lost and shows up again
  2. autoswitch between AP and station modes upon startup. If the Esp32 receives a client on the AP, shut down station. If the Esp32 finds the station, shut down the AP.
  3. add steering wheel switch to shut off hydraulic valve if steering wheel gets turned
  4. show A/D count in WebUI
  5. add Bang Bang valve support (currently untested)
  6. some minor fixes
  7. disabled info tab to reduce burden on ESPUI (after I added widgets, ESPUI no longer worked)
  8. add support for Work and Steer LEDs
  9. use interrupts for steering wheel and steer enable switches, for cleaner code
  10. create unique hotspot by using "Steer module" + mac address to avoid hotspot conflicts

What I'm wondering is: do you want me to create a merge request? Or would you rather review/test it? Or any other concerns you may have?

I hereby disclaim that my changes may depart from your original design, even if I tried to be as unobtrusive as I could.