erinlloyd / Colmar-Academy-Capstone

0 stars 0 forks source link

Summary #8

Open jim-rosales opened 6 years ago

jim-rosales commented 6 years ago

Grade: Exceeds Expectations

Summary: Erin, incredible job on your capstone project! Overall I was thoroughly impressed with your implementation. I loved the design you chose for your project from the color scheme, to the background image you used. The hover effects you used were also a nice touch and very well done. Concerning the structure of your files, I did not see any significant concerns.

The only issues I saw dealt with code style like some off indentation and missing spaces, but those are just stylistic mistakes from the code that don't change the visual aspect of the page. Apart from this just remember to always add an alt attribute to any images you use. The required alt attribute specifies an alternate text for an image if the image cannot be displayed. The alt attribute provides alternative information for an image if a user for some reason cannot view it (because of slow connection, an error in the src attribute, or if the user uses a screen reader).

As a challenge for the mobile version of your project add expandable content so when the user clicks on any of the items below the content that you can view on the desktop version appears. Keep up the good work!

screen shot 2018-01-22 at 4 35 59 pm
erinlloyd commented 6 years ago

Thank you so much for the thorough review and the excellent recommendations!! I truly appreciate your time!