search

erinlloyd / Features_Request_Unit_4

Unit 4 for Codecademy
0 stars 0 forks source link

README missing link to Feature Request document #1

Open ad3429 opened 5 years ago

ad3429 commented 5 years ago

Hi Erin,

It seems you did not link your feature request google doc in your README file. Could you upload the link there, or as a comment below, so that I can access the document and review your projects?

Thanks!

erinlloyd commented 5 years ago

So sorry about that! I’ve reuploaded to GitHub and here is the link to my google doc. Thank you for reviewing my project. I really appreciate it!

On Apr 1, 2019, at 10:05 AM, ad3429 notifications@github.com wrote:

Hi Erin,

it seems you did not link your feature request google doc in your README file. Could you upload the link there, or as a comment below, so that I can access the document and review your projects?

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/erinlloyd/Features_Request_Unit_4/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AOSdRqEGTFJuuwQNQnyX11lGgKSieu-wks5vci5LgaJpZM4cWGMS.

erinlloyd commented 5 years ago

https://docs.google.com/document/d/1mmRmZmBRRrjhyw0Q5mj717dglLlw4_O2vfK2anp5MFs/edit?usp=sharing

ad3429 commented 5 years ago

Thanks! One more thing - can you change the document privileges to allow edit access? Currently there is only view access. Thanks!

erinlloyd commented 5 years ago

Sorry! Should now be editable. Thanks for being so patient with me.

ad3429 commented 5 years ago

Thanks Erin! I've added notes to your google doc. You did a great job overall!

A next possible step if you haven't already done so is to try to actually implement the feature in your jamming project. It's one thing to lay out the feature description/technical implementation, but most of the learning comes from actually implementing the feature. This could also make you see some edge cases that you didn't initially anticipate. You're not required to do this at all, but it could be a fun and rewarding exercise if you have the time for it :)

Nice job overall! :+1:

erinlloyd commented 5 years ago

I intend to try implementing it for sure! Thank you so much for the feedback and for reviewing my project! :D