erinmayg / pe

0 stars 0 forks source link

Unspecified clinic.json behavior #7

Open erinmayg opened 4 years ago

erinmayg commented 4 years ago

Editing the clinic.json file to allow having product duplicates does not clear all data. Instead it takes on the first value it sees.

Steps to reproduce:

  1. update ct/s i/4 pd/Vicodin
  2. update ct/s i/4 pd/Panadol q/1000
  3. Edit the clinic.json file and rename "Vicodin" to "Panadol"

Actual result:

  1. Supplier #4 has product Panadol with quantity = 0.
nus-se-bot commented 3 years ago

Team's Response

The reading of products from the json file is the same as how AB3 read tags from the person json. AB3 also does not clear all data and instead just picks the first value when there are duplicate tags. Hence it is a quirk/flaw that is inherited from AB3.

Regardless, it is unlikely to affect normal operations of the product unless u deliberately edit the json file and add a duplicate value into the same supplier/warehouse, hence its severity is low at most if it is even accepted.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]