Fixing event listener overloads

eritbh / yuuko

🔰 No-frills Discord command framework for Eris

http://eritbh.me/yuuko

MIT License

17 stars 2 forks source link

Fixing event listener overloads #39

Closed Skillz4Killz closed 4 years ago

Skillz4Killz commented 5 years ago

This PR fixes the event listeners for Yuuko. It will no longer override the Eris listeners with the default string overload and just defaults to Eris overloads if none is found in Yuuko.

Note: This PR is pending merging of Eris #dev into master so we can access the interfaces created there and extend those interfaces inside Yuuko. https://github.com/abalabahaha/eris/pull/575

eritbh commented 5 years ago

Solid solution, thanks for this! I'll make sure it gets merged once there's a new Eris release with the upstream changes.

eritbh commented 5 years ago

Don't think you meant to push that last commit to this branch...

Skillz4Killz commented 4 years ago

Whoopsies, ill get that fixed!

Skillz4Killz commented 4 years ago

I believe this should now be ready for review @Geo1088 Eris got updated last night.

eritbh commented 4 years ago

Thanks again!