erithtotl / wall-height

New fork of original project for continued improvements.
https://github.com/erithtotl/wall-height
GNU General Public License v3.0
6 stars 9 forks source link

Very slow token movement when Wall Height is activated #3

Closed FatBiscuit closed 3 years ago

FatBiscuit commented 3 years ago

The features of Wall Height are working fine, but while it's active many PC tokens move especially slow. In other words, there is a significant lag between when I press the up arrow on my keyboard and when the token actually moves. If I disable the Wall Height module, token movement goes back to normal. Any ideas?

FatBiscuit commented 3 years ago

Upon further investigation, this problem is exacerbated by token heights above 0. Tokens at 0 height have only a small amount of movement lag (still more than with the module inactive), but tokens with some height added (10, 20, 30, etc) move with much greater lag.

erithtotl commented 3 years ago

This should be fixed. The issue was with my support for libWrapper for module compatibility. Wrapping the Foundry method 'testwall' resulted in a massive perf hit due to the frequency in which it is called (10s of thousands of times). 3.5.3.2 the newest release should address this.