search

erithtotl / wall-height

New fork of original project for continued improvements.
https://github.com/erithtotl/wall-height
GNU General Public License v3.0
6 stars 9 forks source link

Compatibility Request #8

Closed epicmusic42 closed 3 years ago

epicmusic42 commented 3 years ago

If compatibility with the module Perfect Vision could be made possible that would be awesome! Running PF1 I kinda need Perfect Vision for darkvision to work.

erithtotl commented 3 years ago

What happens when you run them both? Perfect Vision is a much more complex module than wall-height, but I had hoped I'd eliminated any compatibility issues

epicmusic42 commented 3 years ago

It just acts like a normal wall. raising a token to be above or below the wall doesn't let them see past it. as far as i've been able to tell, there's no difference in how the wall effects their vision than if i turn wall heights off.

erithtotl commented 3 years ago

Turning on Tokenvision doesn't break wall height for me, I just tested it.

I have released an update with some bug fixes. In case it was possibly one of the other issues please try with the latest update and let me know.

epicmusic42 commented 3 years ago

it looks like the latest update did fix it! thank you v much!

QuentinLeCaignec commented 3 years ago

I still have issues with Perfect Vision + Wall Height, specifically with "Limited" vision on walls (terrain walls).

Example problem: A character 1 is facing a terrain wall (infinity height), behind is an enemy 2, and behind the enemy is another terrain wall (infinity height). The walls function fine for the map (I can see beyond the first terrain wall but not the second), but I can't see the enemy 2 token behind the first wall (even though my vision shows that part of the map).

This makes it basically impossible to use terrain walls with this combination of mods for me, since even just one terrain wall makes every token behind it invisible.

baileywick commented 3 years ago

Same problem here.

On Sat, Jul 31, 2021, 10:19 AM Quentin Le Caignec @.***> wrote:

I still have issues with Perfect Vision + Wall Height, specifically with "Limited" vision on walls (terrain walls).

Example problem: A character 1 is facing a terrain wall (infinity height), behind is an enemy 2, and behind the enemy is another terrain wall (infinity height). The walls function fine for the map (I can see beyond the first terrain wall but not the second), but I can't see the enemy 2 token behind the first wall (even though my vision shows that part of the map).

This makes it basically impossible to use terrain walls with this combination of mods for me, since even just one terrain wall makes every token behind it invisible.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/erithtotl/FVTT-Wall-Height/issues/8#issuecomment-890378182, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMLTXWSPBJVEO5JCRR25FDT2QWB7ANCNFSM4YKHGBAA .

erithtotl commented 3 years ago

I'll play around with this tomorrow. I've never spent much time looking into how the game processes terrain walls so this should be interesting.