eritislami / evobot

🤖 EvoBot is a Discord Music Bot built with TypeScript + Discord.js, includes Docker builds & localization in 20+ languages
MIT License
1.82k stars 2.02k forks source link

🐛 This interaction failed - Volume Control Past Maximum #1628

Open SugarD-x opened 1 month ago

SugarD-x commented 1 month ago

Describe the bug When actively playing a video, increasing the volume via reaction button when already at 100% causes a This interaction failed error to appear between the reaction buttons. This affects the latest repository version of the bot.

How To Reproduce Steps to reproduce the behavior:

  1. Play a song.
  2. While the volume is at 100%, press the volume up reaction button.
  3. Error appears.

Expected behavior An error message should not appear. A message stating that the volume is already at 100% would likely be a better notification sent via user-only interaction message.

Environment (add if possible)

Additional information & screenshots I have not tested this with the volume down button when already at 0%, but this likely already exists. I am also not sure if starting with lower default volumes and increasing/decreasing to these levels would trigger it or not. (I'd assume so). My default volume via my config.json is already at 100%.