Rewrite for v13? - Githubissues

dylanjamesdev commented 3 years ago

Is a rewrite for djs v13 going to be done? I won't judge if not because djs has become very... irritating.

eritislami commented 3 years ago

I would like to update the bot to use v13, hopefully there won't be any roadblocks with ytdl or any libs that would prevent the migration so I will need some time to test everything.

wolf-yuan-6115 commented 3 years ago

@eritislami Discord.js v13 need Node.js 16.6.1, but ytdl in Node v16 is buggy...

eritislami commented 3 years ago

@eritislami Discord.js v13 need Node.js 16.6.1, but ytdl in Node v16 is buggy...

I'm aware of this, hopefully they fix those issues in the next few months

SrIzan10 commented 3 years ago

True, I needed to revert changes from v13 to v12 using dependabot.

nikosszzz commented 3 years ago

I tried updating mine to discord.js 13 but from what i see after configuring intents: channel.join does not work, says is not a function

wolf-yuan-6115 commented 3 years ago

It changed to @discordjs/voice, so we need to rewrite it...

On Sun, Aug 15, 2021, 00:13 nikoszz @.***> wrote:

I tried updating mine to discord.js 13 but from what i see after configuring intents: channel.join does not work, says is not a function

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/eritislami/evobot/issues/825#issuecomment-898913508, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN4MEDHZM2QZICFE3KEZHLTT42I2LANCNFSM5BX24RHA .

nikosszzz commented 3 years ago

Yeah, i saw yesterday after i said this... i got the voicechannel stuff to join channels work but music is completely broken (queue doesn't work at all neither does the play function)

LackyPal commented 3 years ago

Discord recently announced to use slash commands mostly. message will be a privilege intent soon. So, the search command will not be work this way, you can use select menu for this Also you can use button instead of reaction

dylanjamesdev commented 3 years ago

They released an entire music module, no need for ytdl

Sent from ProtonMail for iOS

On Sun, Aug 15, 2021 at 1:01 AM, nikoszz @.***> wrote:

Yeah, i saw yesterday after i said this... i got the voicechannel stuff to join channels work but music is completely broken (queue doesn't work at all neither does the play function)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

dylanjamesdev commented 3 years ago

Yes loser, however ping prefixes will be allowed so if you ping a bot it’ll still see the message

Sent from ProtonMail for iOS

On Sun, Aug 15, 2021 at 3:05 AM, L0SER @.***> wrote:

Discord recently announced to use slash commands mostly. message will be a privilege intent soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

LackyPal commented 3 years ago

Not a good idea i think, you should use interaction commands ^^

dylanjamesdev commented 3 years ago

Honestly I disagree, slash commands are gonna fail because of discords ignorance that bot developers know what their users want but that’s an option and lord don’t even get me started I’ve said this shit so much in the api server 😂

On Sun, Aug 15, 2021 at 8:07 AM, L0SER @.***> wrote:

Not a good idea i think, you should use interaction commands ^^

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

LackyPal commented 3 years ago

From user perspective, I also want regular command. If two bot has same commands, you can't control which bot will be used when using a slash commands. I'd tested with two music bot, whenever I try to play music, a random one just play . Can't control it

wolf-yuan-6115 commented 3 years ago

You still need ytdl because they just rewrite entire voice module but you still need to process media your self

On Sun, Aug 15, 2021, 20:06 Dylan J. @.***> wrote:

They released an entire music module, no need for ytdl

Sent from ProtonMail for iOS

On Sun, Aug 15, 2021 at 1:01 AM, nikoszz @.***> wrote:

Yeah, i saw yesterday after i said this... i got the voicechannel stuff to join channels work but music is completely broken (queue doesn't work at all neither does the play function)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/eritislami/evobot/issues/825#issuecomment-899040567, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN4MEDEB7TITZJ47ZCR6DZLT46UT3ANCNFSM5BX24RHA .

dylanjamesdev commented 3 years ago

See this example

https://github.com/discordjs/voice/blob/main/examples/music-bot/src/bot.ts

Sent from ProtonMail for iOS

On Sun, Aug 15, 2021 at 10:42 AM, Wolf yuan @.***> wrote:

You still need ytdl because it just rewrite entire voice module but you still need to process media your self

On Sun, Aug 15, 2021, 20:06 Dylan J. @.***> wrote:

They released an entire music module, no need for ytdl

Sent from ProtonMail for iOS

On Sun, Aug 15, 2021 at 1:01 AM, nikoszz @.***> wrote:

Yeah, i saw yesterday after i said this... i got the voicechannel stuff to join channels work but music is completely broken (queue doesn't work at all neither does the play function)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/eritislami/evobot/issues/825#issuecomment-899040567, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN4MEDEB7TITZJ47ZCR6DZLT46UT3ANCNFSM5BX24RHA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

dylanjamesdev commented 3 years ago

Oops my bad, it was buried in there

Sent from ProtonMail for iOS

On Sun, Aug 15, 2021 at 10:44 AM, Dylan James @.***> wrote:

See this example

https://github.com/discordjs/voice/blob/main/examples/music-bot/src/bot.ts

Sent from ProtonMail for iOS

On Sun, Aug 15, 2021 at 10:42 AM, Wolf yuan @.***> wrote:

You still need ytdl because it just rewrite entire voice module but you still need to process media your self

On Sun, Aug 15, 2021, 20:06 Dylan J. @.***> wrote:

They released an entire music module, no need for ytdl

Sent from ProtonMail for iOS

On Sun, Aug 15, 2021 at 1:01 AM, nikoszz @.***> wrote:

Yeah, i saw yesterday after i said this... i got the voicechannel stuff to join channels work but music is completely broken (queue doesn't work at all neither does the play function)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/eritislami/evobot/issues/825#issuecomment-899040567, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN4MEDEB7TITZJ47ZCR6DZLT46UT3ANCNFSM5BX24RHA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

wolf-yuan-6115 commented 3 years ago

Oops my bad, it was buried in there Sent from ProtonMail for iOS … On Sun, Aug 15, 2021 at 10:44 AM, Dylan James @.> wrote: See this example https://github.com/discordjs/voice/blob/main/examples/music-bot/src/bot.ts Sent from ProtonMail for iOS On Sun, Aug 15, 2021 at 10:42 AM, Wolf yuan @.> wrote: > You still need ytdl because it just rewrite entire voice module but you > still need to process media your self > > On Sun, Aug 15, 2021, 20:06 Dylan J. @.> wrote: > >> They released an entire music module, no need for ytdl >> >> Sent from ProtonMail for iOS >> >> On Sun, Aug 15, 2021 at 1:01 AM, nikoszz @.> wrote: >> >> > Yeah, i saw yesterday after i said this... i got the voicechannel stuff >> to join channels work but music is completely broken (queue doesn't work at >> all neither does the play function) >> > >> > — >> > You are receiving this because you authored the thread. >> > Reply to this email directly, [view it on GitHub]( >> #825 (comment)), >> or [unsubscribe]( >> https://github.com/notifications/unsubscribe-auth/ANEQE3U6DPTSBA6IC5AQPPDT45C23ANCNFSM5BX24RHA >> ). >> > Triage notifications on the go with GitHub Mobile for [iOS]( >> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) >> or [Android]( >> https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email). >> >> >> — >> You are receiving this because you commented. >> Reply to this email directly, view it on GitHub >> <#825 (comment)>, >> or unsubscribe >> https://github.com/notifications/unsubscribe-auth/AN4MEDEB7TITZJ47ZCR6DZLT46UT3ANCNFSM5BX24RHA >> . >> > > — > You are receiving this because you authored the thread. > Reply to this email directly, [view it on GitHub](#825 (comment)), or unsubscribe. > Triage notifications on the go with GitHub Mobile for iOS or Android.

They use youtube-dl-exec to get opus ogg stream, but after I tested it, I don't think it's best for Discord music bot. It took too long to process media data

wolf-yuan-6115 commented 3 years ago

@eritislami Hello, I have a modified bot that is using evobot as base, and its written in v13, here is its player.js (Please ignore Chinese strings...) https://github.com/Discord-cat-dev/blackcat/blob/main/include/player.js

wolf-yuan-6115 commented 3 years ago

I'm using ffmpeg to download video because ytdl-core is buggy

SugarD-x commented 3 years ago

I tried updating mine to discord.js 13 but from what i see after configuring intents: channel.join does not work, says is not a function

This is the issue I'm having right now too. Still trying to figure out the problem.

Edit: It looks like Discord annoyingly split the voice stuff into @discordjs/voice, which means we have a lot of work to do...

For example, see subscriptions in here: https://github.com/discordjs/voice/blob/main/examples/music-bot/src/bot.ts (A really dumb naming convention on their part too, if you ask me).

LackyPal commented 3 years ago

You

I tried updating mine to discord.js 13 but from what i see after configuring intents: channel.join does not work, says is not a function

This is the issue I'm having right now too. Still trying to figure out the problem.

You need to use @discord.js/voice, v13 doesn't have in built voice support

SugarD-x commented 2 years ago

Has there been any decision or progress on this so far? I've been able to update my bot that is based on this one, and the only issue I've seen thus far is the channel.join and channel.leave problem preventing music from being played.

nikosszzz commented 2 years ago

Discord API v6 & v7 will be decommissioned at April 30, meaning Discord.JS 11 & 12 will stop working altogether. Is evobot discord.js 13 gonna happen?

wolf-yuan-6115 commented 2 years ago

Well...... idk

On Sat, Mar 5, 2022, 17:36 nikoszz @.***> wrote:

Discord API v6 & v7 will be decommissioned at April 30, meaning Discord.JS 11 & 12 will stop working altogether. Is evobot discord.js 13 gonna happen?

— Reply to this email directly, view it on GitHub https://github.com/eritislami/evobot/issues/825#issuecomment-1059729947, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN4MEDGESXNSJA363YSSKLDU6MTIPANCNFSM5BX24RHA . You are receiving this because you commented.Message ID: @.***>

l0g4n1337 commented 2 years ago

exactly, with the latest discord announcements regarding the suspension of the service for v11 and v12, I hope to see EVO updated. I've tried pretty much all the bots on the web, and EVO is the only one that has everything (including auto-prune) you did a fantastic job thank you.

SugarD-x commented 2 years ago

exactly, with the latest discord announcements regarding the suspension of the service for v11 and v12, I hope to see EVO updated. I've tried pretty much all the bots on the web, and EVO is the only one that has everything (including auto-prune) you did a fantastic job thank you.

Agreed on this. I'm getting very concerned because we've yet to hear a response either way, and the deadline is approaching fast. :(

eritislami commented 2 years ago

@SugarD-x @l0g4n1337 @wolf-yuan-6115 @nikosszzz @L0SER8228 @SrIzan10

Hello all, Im glad to announce that I'm very close to releasing a working version of the bot with the newest discord.js version + discordjs/voice, At the start it will not support slash commands or any of the fancy new features but I hope to get those going slowly in the future, thanks to all who are still using the bot :)

I will be closing any issues or pull requests that are non-relevant to the future of the bot with discord.js@13

eritislami / evobot

Rewrite for v13? #825