Closed jiafu1115 closed 10 years ago
@eriwen I have test it in my project include add option: -w and -k, So if you think need some unit tests for added features, I will add it into test_lcov_to_coberuta_xml. Many thanks to you and I hope you can review my codes and merge the request. I am using the tool in my daily jobs.
@jiafu1115 I see, so you are converting the gcov to lcov and then running lcov processing over all the generated files.
I think that perhaps we could pull pieces of your logic to separate methods (for example, lines 358-373 and lines 375 to 382). You might be able to fake input to these methods and verify their output (and if not, can you think of a way you could do that?)
@eriwen agree with you, I will extractor the code logical to methods to improve readable.
I will refractor the code tomorrow and test it, now it is 1:43 evening in China,I had to go sleep now,Thanks for your suggestions.
@jiafu1115 Sounds good. Take your time :)
cancel this request and repost newest request
cancel this request and repost newest request
the newest pull request . add -w and -k to change the default handle if using gcov data.