search

eriwen / lcov-to-cobertura-xml

Converts lcov output to Cobertura-compatible XML for CI
https://eriwen.github.io/lcov-to-cobertura-xml/
Apache License 2.0
187 stars 73 forks source link

I had refractor my code and test it #17

Closed jiafu1115 closed 10 years ago

jiafu1115 commented 10 years ago

@eriwen I had complete refractor for last pull request's code by extractored methods to express clearly,add basic validation,etc. At last, I test it with followed cases: 1 -w on/off 2 -k on/off 3 1basic+2append 4 3append 1 only basic info 2 only append info and What's more I use jenkins to publish the result, it is all OK. So can you help to review my code and request and take a merge now, Thanks a lot. PS: I will close the last pull request.

eriwen commented 10 years ago

@jiafu1115 The refactoring looks good. I'd still like to test this myself and perhaps write some unit tests if possible. For now I have merged this into the gcov branch and will merge this into master and release when it's ready.

Thank you very much for your contribution!

jiafu1115 commented 10 years ago

@eriwen , ok, 3ks for your review and expect we can provide more amazing features to more peoples.