search

erixtekila / gitbook-plugin-richquotes

Gitbook plugin : Transform annoted quotes to notes
Apache License 2.0
49 stars 14 forks source link

User defined tag #14

Closed leesei closed 8 years ago

leesei commented 9 years ago

Allow user to define tags in config:

"pluginsConfig":
{
    "richquotes" : {
        "star" : {
            "alert": "warning",
            "picto": "fa-star"
        }
    }
}
leesei commented 9 years ago

Please check my branch at leesei/gitbook-plugin-richquotes.

Now that user can define annotations, I think we can trim down the built-in ones. Please comment before I submit PR.

leesei commented 9 years ago

Any comments on this?

erixtekila commented 9 years ago

Sorry, no time now.

glueckpress commented 9 years ago

My javascript is not far from superb, but @leesei’s code looks decent to me there, and it obviously solves a potential issue with localization. Currently I cannot use the plugin in any other language than English; with @leesei’s branch I can. Would love to see it merged.

leesei commented 9 years ago

I'm thinking of pushing my repo to NPM. Anyone interested can use 

npm install https://github.com/leesei/gitbook-plugin-richquotes

to use my branch.

erixtekila commented 9 years ago

Sorry for the delay @leesei I've look after your proposals. Why don't you send a PR, I'll update the repo.

leesei commented 9 years ago

'K.

On Tue, Oct 6, 2015 at 4:37 PM, Eric Priou notifications@github.com wrote:

Sorry for the delay @leesei https://github.com/leesei I've look after your proposals. Why don't you send a PR, I'll update the repo.

— Reply to this email directly or view it on GitHub https://github.com/erixtekila/gitbook-plugin-richquotes/issues/14#issuecomment-145783778 .

glueckpress commented 9 years ago

@leesei Thank you! @erixtekila For the record, meanwhile GitBook may have started working on a similar plugin. Slack archive URL for reference: https://gitbook-community.slack.com/archives/general/p1443713075000136.