erixtekila / gitbook-plugin-richquotes

Gitbook plugin : Transform annoted quotes to notes
Apache License 2.0
49 stars 14 forks source link

blockquote, p > strong strong, not supported #6

Closed anibalsanchez closed 9 years ago

anibalsanchez commented 10 years ago

Hi,

If there's more strong text in the paragraph (beyond the richquote declaration), then richquotes are disabled and it just outputs

Warning ... more ...

That's beause $strong.text().toLowerCase() concatenates all strongs (warningmore), thus a richquote, such as Warning, can't be detected.

Please, add a note to document the limitation. (It was driving me crazy ;-) )

Thanks!

erixtekila commented 10 years ago

Would you mind post a test case example please ? Thanks.

anibalsanchez commented 10 years ago
> **Note** Acknowledgement: This **documentation** is generally inspired

In this example, Note and documentation generate Notedocumentation.

alexandreaquiles commented 10 years ago

Corrected by PR #7.

aschempp commented 9 years ago

I guess this can be closed as PR #7 has been merged :-)

erixtekila commented 9 years ago

yep, you're right

leesei commented 9 years ago

FYI, the update code was not pushed to NPM.

erixtekila commented 9 years ago

@leesei I'll doucble check this. Thanks.