erjadi / kubecraftadmin

MIT License
992 stars 33 forks source link

Fixed issue with Position core dumps, added statefulsets and daemonse… #24

Closed ktenzer closed 3 years ago

ktenzer commented 3 years ago

…ts as well as improved k8s client config to be dynamic/automated

erjadi commented 3 years ago

Hi Keith thanks for picking this up. I'll need some time to go through it but I appreciate the efforts.

Some first questions:

ktenzer commented 3 years ago

They are optional, they just check if env variables namespaces and accessWithinCluster are set. The accessWithinCluster if set to true will use k8s to auth which requires some rbac permissions or if false will use KUBECONFIG env/config

Yes the only workaround to issue is to use a command to not use the method player.Position as this core dumps. The downside of the command is it output everytime the coords as you move. So you need to move a few spaces then init, step on beacon and then you are good.

I can try to do this without the onTravel function to make it smoother.

I will close this pull request and do a new one later with changes above