Closed ktenzer closed 3 years ago
Hi Keith thanks for picking this up. I'll need some time to go through it but I appreciate the efforts.
Some first questions:
Did you mean to include the config file? It seems to refer to your testclusters... Yeah that was config from old throw away cluster but yeah that is not needed
Could you reinstate the azure-pipelines.yml? It is necessary to build the image over at docker.io/erjadi Yes I removed it because I am not using this but i can put it back
Could we keep the command line arguments optional? In the documentation it originally is stated we can start with a certain command line (and optional namespace arguments).
They are optional, they just check if env variables namespaces and accessWithinCluster are set. The accessWithinCluster if set to true will use k8s to auth which requires some rbac permissions or if false will use KUBECONFIG env/config
Yes the only workaround to issue is to use a command to not use the method player.Position as this core dumps. The downside of the command is it output everytime the coords as you move. So you need to move a few spaces then init, step on beacon and then you are good.
I can try to do this without the onTravel function to make it smoother.
I will close this pull request and do a new one later with changes above
…ts as well as improved k8s client config to be dynamic/automated