Generated auto discovery topics don't conform to 2023.8.0+ specification

erkexzcx / valetudopng

A Valetudo map renderer (ex Hypfer/ICantBelieveItsNotValetudo) for Home Assistant.

https://valetudo.cloud/

Apache License 2.0

39 stars 6 forks source link

Generated auto discovery topics don't conform to 2023.8.0+ specification #6

Closed mundschenk-at closed 10 months ago

mundschenk-at commented 10 months ago

Describe the bug The entity names generated for Home Assistant still contain the device name as a prefix. That practice has been deprecated with Home Assistant 2023.8.0 and currently results in warnings printed to the log file (which will probably become errors later next year). The auto discovery topics generated by Valetudo were fixed in Valetudo 2023.10.0

Expected behavior No warnings/errors in the log file.

erkexzcx commented 10 months ago

Thank you so much for reporting this. I will look into this at some time.

For reference - https://github.com/Hypfer/Valetudo/commit/9d0fed13cbb6b20ccbb3a0e79111382bcda6b9fc

erkexzcx commented 10 months ago

If I understood the issue correctly - it should be fixed with v1.0.15. Looks like I no longer see those warnings in HA logs as well. Please re-open if issue still persists.