search

erkin / ponysay

Pony rewrite of cowsay.
GNU General Public License v3.0
1.22k stars 82 forks source link

string replacement in shell completion install paths is too optimistic #223

Closed tdsmith closed 9 years ago

tdsmith commented 9 years ago

If the install prefix contains "ponysay" it will be replaced incorrectly by the name of each tool while installing shell completions.

e.g. what should be /usr/local/Cellar/ponysay/3.0.2/share/bash-completion/completions/ponythink is accidentally installed as /usr/local/Cellar/ponythink/3.0.2/share/bash-completion/completions/ponythink.

It's introduced by this line: https://github.com/erkin/ponysay/blob/6658221bbf1540fb773be7e3c1690c09d9720072/setup.py#L609