Fix build system once and for all

erkin / ponysay

Pony rewrite of cowsay.

GNU General Public License v3.0

1.22k stars 81 forks source link

Fix build system once and for all #94

Open svenstaro opened 12 years ago

svenstaro commented 12 years ago

Really, the build system is still a mess. I can't even update ponysay in the official repos in its current state.

Remove configure/Makefile.
Make a standard setup.py. See here for a nice one and here and here for how to write it. distutils is not only for Python modules but also for data and scripts! It just happens to work especially well for modules as it has a lot of automagic in that regard but we don't need to use that. The current build system is way more complicated than it possibly needs to be. We certainly don't need to go full Debian here. Never go full Debian.
Fix the README to reflect the new changes.

maandree commented 12 years ago

»Full Debian» what is that?

Why wouldn't you be able to build ponysay and update it the arch's repo, building ponysay in a chroot enviromnent works? It just that the script is a little more complicated than needed.

svenstaro commented 12 years ago

It's not a lot of fun because the parameters change each time. What are the correct parameters to build it in a chroot for /usr prefix right now? If you tell me, I can update the package.

And "going full Debian" is a corruption of "going full retard", essentially this means overdoing it. I was implying that the build system is over complicated and over engineered.

maandree commented 12 years ago

Either of the following will do:

./setup.py install

./setup-py PREFIX=/usr install

./setup.py --prefix=/usr install

I recommend adding --everything --without-pdf-compress after ./setup.py

maandree commented 12 years ago

When this is done split the ponysay.py file into one file class, and one for the main method