Extension not working on some embedded videos

[dnmTX]

Windows 10 x64 Enterprise LTSB 1607 Slimjet Browser (based on Chromium 68.0.3440.75) (Official Build) (64-bit)

Extension doesn't kick in on some embedded videos as observed here: http://www.guru3d.com/news-story/military-operations-benchmark-released.html

I'm hoping that dev still maintaining it and the issue will be resolved.We need it working,helps a lot on older systems.Thank you.

[erkserkserks]

Can't reproduce with that page right now, but I have seen it occur rarely in the past - not exactly sure what triggers this.

Does this always happen on that page for you?

[dnmTX]

@erkserkserks it actually start happening on every page with embedded youtube link.On the actual youtube site the extension is working as intended.Here is more fresh links:

https://www.techpowerup.com/247624/katamari-damacy-comes-to-the-pc-as-a-remastered-edition

https://www.guru3d.com/ (scroll down until you see the player-Forza Horizon 4 video)

P.S. If there is a way on my side to do a debug log or something let me know.

[dnmTX]

@erkserkserks i was looking into the page code(not sure if this is matter but just in case) and the player is fetched from s.ytimg.com domain.The actual link is: https://s.ytimg.com/yts/jsbin/player-vflkUTZn2/en_US/base.js Will attach the script where i found all the codecs listed,hopefully can help you figure it out why it doesn't work. base.zip

P.S. I'm also using Youtube Auto HD+FPS extension which doesn't work either. (IN techpowerup.com)

[dnmTX]

.....errors that i see in chrome dev tools(guru3D.com):

Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document. at chrome-extension://aleakchihdccplidncghkekgioiakgal/src/inject/content_script.js:30:1

[dnmTX]

UPDATE: Ok...i got it working at guru3d.com.Had to allow cookies for youtube.com to be stored.Third party cookies were disabled that's why.No luck at techpowerup.com though.No errors showing in dev tools,i'm out of ideas on this one.

[avi12]

My (unrelated) extension had the same problem that webpages with embedded videos like the techpowerup.com didn't work, and I solved it. I pulled the repository and made some changes, but when tried to commit & push - got an error. How can I push my fix?

[erkserkserks]

@avi12 If you want to push to this repository, you'll have to create a pull request first.

@dnmTX Try the new version (v1.0.9) of h264ify. I've added more youtube domains that this extension will run on, which should solve your issue.

[dnmTX]

@erkserkserks tested,finally success 👍 on techpowerup.com. Good job,thank you for fixing it.The difference is,to make it work i had to allow youtube-nocookie.com to store cookies as i did for guru3d.com. With @avi12's extension,after he pushed the fix i didn't have to do that.Still,it works so i'm happy. @avi12 thanks for pitching in man,very much appreciate the effort 👍

[avi12]

@avi12 If you want to push to this repository, you'll have to create a pull request first.

I pulled via WebStorm, then attempted to commit & push. Still got that error

@avi12 thanks for pitching in man,very much appreciate the effort 👍

No problem 😄

[dnmTX]

@avi12

I pulled via WebStorm, then attempted to commit & push. Still got that error

You can do it straight from the browser here,no need of additional programs for that.It's really easy,once you've done the changes you'll see there is a button to make a pull request. I've done it several times and i'm not a coder or something(very limited knowledge),pretty sure it will be "walk in the park for ya" 👍

P.S. I see you pushed another update and i was looking at the extension's details and in "Permissions" there is a line: "Read your browsing history".What's up with that,is that telemetry? I'm kind of very much against anyone collecting data from my system(i hope i'm wrong though cause i like the extension).Can you give some more info please.

[avi12]

Well, I have no idea what is it talking about. From my manifest: Maybe the permissions are associated with another extension?

EDIT:: After removing & restoring lines, turns out that the "tabs" permission is responsible for the browsing history permission

[dnmTX]

Oh...i see,well,that make sense.Thanks for clarifying it @avi12 ,just had to make sure. Cheers!

[avi12]

And since it didn't seem to break anything in my extension, I removed it. One less permission

[avi12]

Well, turned out it did break something, so I returned it. Thanks to the permission, the user can change his size preference, whenever he wants to. If he changes the size outside of YouTube, the extension will set a cookie in YouTube so the change will take effect.

[dnmTX]

@avi12 i saw that you added it back.Now that we all know what it does,and it's not telemetry it's all good. Thanks for the great job man,much appreciated. 👍

[dnmTX]

Closing this to reduce the clutter.Thank you @erkserkserks and @avi12 .Keep up the GOOD WORK guys!