search

erkyrath / lectrote

The IF interpreter in an Electron shell
Other
250 stars 28 forks source link

npm run scripts and dependencies for building OSX dist #6

Closed dmison closed 8 years ago

dmison commented 8 years ago

includes support for building .icns file from SVG as required for OSX build for correct icon

I also added support for rebuilding icon-128.png from the SVG as well because it was there. :-)

The resulting .app is about a 3rd the size of the current download

dmison commented 8 years ago

urrgh . stupid. I rebased my local and pushed it back to github hence extra commits :-(

dmison commented 8 years ago

redo

erkyrath commented 8 years ago

Thanks. I will look at this next week. electron-packager was already on my radar.

When you say the app is smaller, do you know what's omitted?

dmison commented 8 years ago

it symlinks a few things instead of multiple copies, eg. Electron Framework.framwork/Versions/Current to Electron Framework.framwork/Versions/A.

Looking now I'm wondering if the fact that they weren't symlinked in your download might have been a result of the filecopy in makedist.py because they are definitely symlinked in electron-prebuilt