search

erkyrath / lectrote

The IF interpreter in an Electron shell
Other
248 stars 28 forks source link

Open dialog does not highlight .z5, .z8, etc #75

Closed erkyrath closed 7 years ago

erkyrath commented 7 years ago

Did I screw up the plist info? Maybe I can't have an array of extensions inside one entry.

erkyrath commented 7 years ago

Because you forgot to update the showOpenDialog call, genius.

ffilipus commented 7 years ago

Win64 1.1.8 release still doesn't show *.z8 files.

erkyrath commented 7 years ago

I am now including z5 and z8 in the dialog filters list. I don't know what else is necessary.

erkyrath commented 7 years ago

I tested this on Win7 and Win10. Windows has a file-type control on the right side of the file dialogue; you have to select "Z-code" in order to see .z5 and .z8 files. Seems weird to me, but I guess that's how Windows is supposed to work.

curiousdannii commented 7 years ago

The Windows convention would be for the default to be an "All games" type, which would be the union of all the sub types. Often there is also an "All files" type too, which uses a "*" filter.

From what I could see there's no shortcuts in Electron for defining the union filter, it would just need to be manually specified.