search

erkyrath / lectrote

The IF interpreter in an Electron shell
Other
248 stars 28 forks source link

Set app name and icon. #88

Closed RedHatter closed 7 years ago

RedHatter commented 7 years ago

This pull request does two things.

  1. Starts lectrote with electron . instead of pointing to main.js directly. This was causing electron to bypass the package.json and erroneously set the app name as electron.

  2. Sets the app icon whenever a new window is opened.

erkyrath commented 7 years ago

I've pulled in the change with electron . -- thanks.

I'm not sure about using icon-128.png as a window icon. On MacOS this isn't used, and on Windows windows inherit the .ico from the .exe file, which is preferable. (Particularly for bound apps, which won't use Lectrote's icon-128 anyway.)

I take it you are using Linux? It might make sense to add the icon field to the window options on Linux only.

RedHatter commented 7 years ago

Yes, I use linux (KDE Neon to be exact). Does the current solution have any adverse affects on the other systems or do they simply ignore it?

Only adding the icon on Linux should work fine.

curiousdannii commented 7 years ago

Does Electron let you use svg icons in Linux? That would be preferable.

RedHatter commented 7 years ago

I believe linux does support svg app icons but I was unable to get it working with electron.

erkyrath commented 7 years ago

The adverse effect would be on Windows. The generic Lectrote .png image shouldn't replace the app-specific .ico image.

I'll set it up on Linux only.