search

erkyrath / quixe

A Glulx VM interpreter written in Javascript
http://eblong.com/zarf/glulx/
MIT License
169 stars 33 forks source link

Super big speedup for pop_callstub #13

Closed eevee closed 8 years ago

eevee commented 8 years ago

Spent a few hours looking, and this was the only major improvement I found.

7% improvement on Firefox, 16% improvement on Chromium. (Measuring Counterfeit Monkey's startup time, as usual.)

erkyrath commented 8 years ago

Okay, you win, there was easy fodder left. I owe you a drink and/or pastry. :)

erkyrath commented 8 years ago

Um, hm. I have tested this under current Safari, Firefox, and Chrome (not Chromium) and there is no clear difference. Your change might be 1% to 2% slower.

erkyrath commented 8 years ago

Ok, on Lectrote's Chromium I see the difference.

I think Chrome just updated, let me try it again...

erkyrath commented 8 years ago

Yup. No improvement in Chrome 44, which is what I had before. But in 47 (the Lectrote package) or 48 (the latest Mac desktop package) it is visible. I'm getting more like 10% than 16%, but hey -- good enough.

erkyrath commented 8 years ago

Credit as "Eevee" or what name?

eevee commented 8 years ago

I'm mostly known as Eevee, yeah :)