erkyrath / quixe

A Glulx VM interpreter written in Javascript
http://eblong.com/zarf/glulx/
MIT License
169 stars 33 forks source link

@mul opcode #2

Closed erkyrath closed 9 years ago

erkyrath commented 10 years ago

Dannii:

I was looking at Quixe and realised that your @mul implementation is inaccurate because Javascript numbers only have 53 bits of precision. You should look into using Math.imul() (this page https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/imul has a polyfill), and perhaps also add some unit tests to glulxercise for big multiplications.

erkyrath commented 9 years ago

Fixed.