search

erkyrath / quixe

A Glulx VM interpreter written in Javascript
http://eblong.com/zarf/glulx/
MIT License
169 stars 33 forks source link

GiLoad will download the story file even if it's provided #38

Open curiousdannii opened 5 years ago

curiousdannii commented 5 years ago

https://github.com/erkyrath/quixe/blob/12d43e17f399fd3bc008397f1aff0d91538d4678/src/quixe/gi_load.js#L221-L223

This should just be if (image) { shouldn't it?

erkyrath commented 5 years ago

I think I decided that, since the ?story= parameter can be added after the fact, it should override the image configuration parameter.

curiousdannii commented 5 years ago

Do you mean through the Web History API (history.pushState)? That's an odd use case, but okay.

I'd like to be able to use GiLoad in Parchment without modification and be able to pass it the image buffer to use. So maybe there could be an extra option to say to not download it if ?story exists, or the reverse (I'd prefer explicit opt-in to overriding the image, but your choice.)

erkyrath commented 5 years ago

By "after the fact", I meant by the user, typing manually in the URL bar. Or by any page that generates a URL for the user to click on, referring to an established interpreter setup.

If you're passing in the image buffer, shouldn't gameurl be null?

(Apologies for the long response time, things slip by.)