Miscellaneous quality-of-life improvements

erkyrath / quixe

A Glulx VM interpreter written in Javascript

http://eblong.com/zarf/glulx/

MIT License

169 stars 33 forks source link

Miscellaneous quality-of-life improvements #4

Open eevee opened 9 years ago

eevee commented 9 years ago

These made hacking on Quixe easier for me:

Replaced src/glkote with a submodule, which requires some light git maintenance (git submodule update --init is enough 90% of the time) but saves you from frequently copying between repos.
Fixed build.py to run with Python 3. (Arch Linux points python at Python 3.)
Stripped all trailing whitespace from the Quixe source. (I have some vim plugin that does this on save, and it kept adding tons of patch noise.)
Cut out layouttestpane and instead generate it automatically, which cuts out a big chunk of the HTML a user has to stick in a file. This is the only part to require an actual glkote bump: erkyrath/glkote#4
Blindly replace == with ===, in the vain hope that it'll be slightly faster. As far as I can tell, it wasn't. Oh well.

eevee commented 9 years ago

Rebased away the .gitignore.

sukima commented 9 years ago

:+1:

erkyrath commented 9 years ago

I've applied the build.py change and the removal of layouttestpane. As for the rest...

The submodule change is a reasonable thing to ask, but I don't want to mess with that workflow right now. The submodule sync command isn't actually any easier (for me) than just copying the files over.

Removing trailing whitespace is futile; it will drip back in again as I edit code.

Blind changes are never a great idea. :/

sukima commented 9 years ago

Removing trailing whitespace is futile; it will drip back in again as I edit code.

You need a better editor then. :imp: Snarking aside, your preferred editor doesn't have a trailing white space option?

erkyrath commented 9 years ago

I'm sure it does. Does your editor have an option to not strip it?

eevee commented 9 years ago

The nice thing about submodules is that you don't even need separate checkouts; commit inside the submodule, commit outside the submodule, you're done. Between commits you don't have to copy anything at all. You only need to do the sync dance if someone else makes changes, which looks to be fairly uncommon. :)

Sure. Doesn't bother me, just was an easy gotcha to fix.

And yeah that's fair. :)