Use flexbox for input element instead of calculating width manually

erkyrath / quixe

A Glulx VM interpreter written in Javascript

http://eblong.com/zarf/glulx/

MIT License

169 stars 33 forks source link

Use flexbox for input element instead of calculating width manually #40

Closed juhana closed 4 years ago

juhana commented 4 years ago

plus some other modern CSS features

curiousdannii commented 4 years ago

This should probably be made at https://github.com/erkyrath/glkote

Does this fix the bug of #32? Or is something like https://github.com/erkyrath/glkote/pull/28 also needed?

juhana commented 4 years ago

Oops, didn't notice that Glkote has a separate repo. (It could be added as a subrepository here to avoid the need for syncing it manually.)

I don't think this fixes the Android bug, I assume the problem is removing and re-adding the input field? I can try it though. This is in response to https://intfiction.org/t/quixe-chrome-cursor-position/42413

juhana commented 4 years ago

There doesn't seem to be any difference in Android, although it's not as bad as #32 describes: City of Secrets doesn't get stuck anymore but the keyboard bounces up and down between turns.

erkyrath commented 4 years ago

Closing this, as it doesn't seem to do what we need and the Chrome bug has been fixed already. See comments at https://github.com/erkyrath/glkote/pull/36 .