erkyrath / remglk

A remote-procedure-call implementation of the Glk IF API
http://eblong.com/zarf/glk/index.html
MIT License
26 stars 14 forks source link

No Highlight on Menu #30

Open cibersheep opened 5 years ago

cibersheep commented 5 years ago

Using Beyond Zork the first menu doesn't show any difference between highlighted and not-highlighted item, when moving through the menu this is the json answered:

{"type":"update", "gen":6,
 "content":[
 {"id":28, "lines": [
  { "line":6, "content":[{ "style":"normal", "text":"               Begin using a preset character                     "}]},
  { "line":7, "content":[{ "style":"normal", "text":"               Select a preset character                          "}]}
 ] }
 ],
 "input":[
 {"id":25, "gen":6, "type":"char" }
 ]}

Is this a bug?

curiousdannii commented 5 years ago

Which interpreter? Remglk is just going to pass along what it was given.

cibersheep commented 5 years ago

True. I compiled against Frotz. Should I file the bug there?

cibersheep commented 5 years ago

Oh, I see... using bocfel shows this:

 {"id":32, "lines": [
  { "line":7, "content":[{ "style":"normal", "text":"               Select a preset character                          "}]},
  { "line":8, "content":[{ "style":"normal", "text":"              "}, { "style":"alert", "text":" Randomly generate a new character "},

So, it must be a frotz issue

DavidGriffith commented 5 years ago

I've never tried compiling this against Frotz. My general approach to Frotz has been to not get it too close to GLK to avoid problems with V6 games and to preserve extreme backward compatibility. How did you get it compiled against Frotz?

I'll continue with this issue at https://gitlab.com/DavidGriffith/frotz/issues/109, but please leave this open until we have conclusively identified where the bug is.

cibersheep commented 5 years ago

I think was a project to have all terps ready to being build for different implementations. There's a list on Github and I've managed to build them for x64 and for armhf :)

DavidGriffith commented 5 years ago

That version of Frotz is quite a bit removed from the current codebase. I suppose what I can do is fold in the changes from glkFrotz as a new interface and see if the bug remains.

cibersheep commented 5 years ago

It looks quite old to be honest but I couldn't find any more modern version. Ahh, I didn't knwo SCUMM had glk support

curiousdannii commented 5 years ago

Having glk support upstream would be good, then Garglk, SCUMM, and all the others could both contribute any changes they have, as well as pull down the current code.

DavidGriffith commented 5 years ago

@dreammaster of ScummVM has very graciously contributed to Unix Frotz. He figured out how to correctly rewrite the palettes of pictures in V6 games where this is needed, first for his GLK interface and then for my SDL interface. I was having loads of trouble translating how it was done in C++ for Windows Frotz into straight C.