search

erland / erlandplugins

Automatically exported from code.google.com/p/erlandplugins
2 stars 5 forks source link

i18n improvement for Song Lyrics #105

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Which plugin is the bug/enhancement related to ?
SongLyrics
What version of SlimServer/SqueezeCeneter are you using? On what operating
system?
7.5.3 / Debian Squeeze / ARM

Could you describe the problem or enhancment ?
Song lyrics has an i18n string for the menu item text, but doesn't use it. 
Instead, it uses the (hardcoded) English string. Attached patch fixes that.

Please note there are more places that could be fixed like that, especially the 
description and the various items in the LastFM module of SongInfo. If you 
like, I can make up a patch for those, too.

Original issue reported on code.google.com by dannybau...@web.de on 4 Jan 2011 at 12:25

Attachments:

GoogleCodeExporter commented 9 years ago 
If you make a patch I'll commit it and include it in the next version. I think 
it's most important to do it in the normal user interface, it's not a big issue 
of the settings pages aren't i18n localized.

I've already applied the hard coded "Song Lyrics" text patch you provided, so 
that will be included in next version.

Original comment by erlan...@telia.com on 4 Jan 2011 at 12:45

GoogleCodeExporter commented 9 years ago 
Thanks for the quick reply. I agree that the player UI is most important, in 
fact that's where my motivation started (I wanted to have the main UI of my 
controller completely in German) ;-)
I think, though, that it also doesn't harm to have all user-visible strings 
localizable. I have attached two patches (SongInfo and SongLyrics) for that. I 
didn't test them yet, though, mainly because I can't do so at the moment. If 
you can, please give them a short test, if you can't, please tell me and I'll 
give them a short test when I have time.

Thanks for your efforts anyway :)

Original comment by dannybau...@web.de on 4 Jan 2011 at 1:20

Attachments:

GoogleCodeExporter commented 9 years ago 
Patches adjusted, committed and tested, will be included in next version.

Original comment by erlan...@telia.com on 5 Jan 2011 at 8:57