search

erland / erlandplugins

Automatically exported from code.google.com/p/erlandplugins
2 stars 5 forks source link

Skipping of 'zapped' songs does not work due to SQL query; patch included #88

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Which plugin is the bug/enhancement related to ?
CustomSkip 2.3.3

What version of SlimServer/SqueezeCeneter are you using? On what operating
system?
7.4.1 r28947 on Debian Linux etch

Could you describe the problem or enhancment ?
'Zapped' songs were not being skipped by a CustomSkip 2.3.3 rule.  I did
some digging and ended up changing the SQL query used when looking for
tracks in the Zapped playlist, and it now works. I have attached a patch file.

This is a fresh install of squeezebox server 7.4.1 and CustomSkip 2.3.3.  I
just installed all of this for the first time. I have no idea if the
structure of the mysql database may have changed from a previous version,
so this patch may very well break things on a different version!  I'm also
not a SQL expert, so there may be a more efficient way to do the query.

Thanks,
Lee

Original issue reported on code.google.com by LeeZiege...@gmail.com on 25 Oct 2009 at 11:49

Attachments:

GoogleCodeExporter commented 9 years ago 
Sorry; that patch was not right.  It failed when there was more than one 
playlist. 
Try this patch instead.

Original comment by LeeZiege...@gmail.com on 26 Oct 2009 at 1:21

Attachments:

GoogleCodeExporter commented 9 years ago 
The original query in Custom Skip 2.3.3 works in my setup, so I'm pretty sure 
the
query isn't the problem.

Do you see any other errors in the server.log ?
Could you run with Custom Skip debug logging enabled and play a track which is 
in the
zapped playlist ?

Original comment by erlan...@hotmail.com on 26 Oct 2009 at 5:02

GoogleCodeExporter commented 9 years ago 
Erland,

Thanks for looking into this.

I'm about to leave town for several days, so I won't have time to do any 
additional
testing until the weekend.  However, I've attached a file with some of the log
entries during the time I was debugging the problem yesterday.  I hope it 
helps.  I
realize you can't see where I put my debug statements into your code (and I've
already removed them) but hopefully they will be fairly self-explanatory.

Thanks,
Lee

Original comment by LeeZiege...@gmail.com on 27 Oct 2009 at 12:52

Attachments:

GoogleCodeExporter commented 9 years ago 
I'd already fixed this in my development version, so that's the reason I didn't 
see
the problem in my own setup. It will be part of the 2.3.4 release.

Original comment by erlan...@hotmail.com on 27 Oct 2009 at 3:31