search

erlandranvinge / ReAttach

The ReAttach Visual Studio Extension
117 stars 36 forks source link

Installation in Visual Studio 2019 Preview #19

Closed MSeifert04 closed 5 years ago

MSeifert04 commented 5 years ago

Following the blog post https://blogs.msdn.microsoft.com/visualstudio/2018/09/26/how-to-upgrade-extensions-to-support-visual-studio-2019/ this makes ReAttach compatible with Visual Studio 2019 Preview

erlandranvinge commented 5 years ago

Hey. Thanks! However, as usual when there's a major Visual Studio update, there is more to it. Once the config changes has been made, there's a new pesky warning inside Visual Studio telling you that the package will stop working mid-cycle due to changes in how packages are loaded and executed. Apparently, from 2019 one have to "asyncify" the package. In the case of ReAttach, this means changing base class to AsyncPackage and changing a lot of calls to invoked asynchronously. However, not all calls are trivial to convert. If you want to give it a shot I'll certainly appreciate it. Otherwise I'm likely gonna do it once I find the time. Hopefully before the release of VS2019.

MSeifert04 commented 5 years ago

You're right. I was wondering where that message came from. Normally I don't pay to much attention to preview messages because they aren't always accurate.

I'm not sure if I have time to follow up on the async package stuff. Is that a blocker for this PR?

Thank you for your answer @erlandranvinge