erlang-ls / erlang_ls

The Erlang Language Server
https://erlang-ls.github.io/
Apache License 2.0
620 stars 136 forks source link

erlang_ls (Emacs) erroring on `linum-mode` #1445

Closed uwiger closed 6 months ago

uwiger commented 11 months ago

Describe the bug erlang_ls (emacs) quit working today. It kept working in nvim, so apparently an emacs problem.

I updated to erlang_ls 0.48.0, scratched the erlang_ls cache as well as the ~/emacs.d/, and ran with the erlang_ls/misc/dotemacs

Still, an error occurred loading the first erlang file:

File mode specification error: (void-function linum-mode)

When applying this change, it got going again:

diff --git a/misc/dotemacs b/misc/dotemacs
index 77ac8b0..c6ceeee 100644
--- a/misc/dotemacs
+++ b/misc/dotemacs
@@ -41,7 +41,7 @@
 (setq lsp-log-io t)

 ;; Show line and column numbers
-(add-hook 'erlang-mode-hook 'linum-mode)
+;; (add-hook 'erlang-mode-hook 'linum-mode)
 (add-hook 'erlang-mode-hook 'column-number-mode)

 ;; Enable and configure the LSP UI Package

Context

plux commented 10 months ago

This is not an erlang_ls issue, but an emacs issue. :)

linum-mode was removed from Emacs 29.

The recommended way these days is to use display-line-numbers-mode.

Hope that helps!