erlang-ls / erlang_ls

The Erlang Language Server
https://erlang-ls.github.io/
Apache License 2.0
620 stars 136 forks source link

Bump erlfmt to upstream 1.3.0 #1469

Closed gomoripeti closed 5 months ago

gomoripeti commented 6 months ago

Description

Since previous version used erlfmt added support for map comprehensions, maybe expressions and some exotic macros. There are some dialyzer warnings pending https://github.com/WhatsApp/erlfmt/pull/352. Variable scope handling was recently improved in erlang_ls for list comprehensions. It needs to be extended to binary and map comprehensions as well, which this PR does not address.

Fixes # .

gomoripeti commented 5 months ago

Only failing testcase is els_docs_SUITE ==> invalidate: FAILED timing out on OTP 23, but it seems to fail on main as well.

So this PR is read for review. (Don't have to wait for erlfmt PR as the dialyzer warning is silenced, thanks for the idea :) )

plux commented 5 months ago

Good stuff @gomoripeti !