using fun() in breaks follow-up specs attributes formatting

[TheGeorge]

[KornelH]

As I remember I fixed some of these highlight issues in https://github.com/pgourlain/vscode_erlang. Unfortunately this repo is based on the same source that was used by vscode_erlang so the updates are now gone from vscode_erlang. I plan to create a pull request for this repo and then uplift this submodule in vscode_erlang to get back the updates.

[TheGeorge]

I'm quite sure we merged the fixes from vscode_erlang into this repo and use the grammar here for both plugins.

Also this issue might be fixed already (it's quite old).

On Tue, Jun 29, 2021, 13:17 Kornel H @.***> wrote:

As I remember I fixed some of these highlight issues in https://github.com/pgourlain/vscode_erlang. Unfortunately this repo is based on the same source that was used by vscode_erlang so the updates are now gone from vscode_erlang. I plan to create a pull request for this repo and then uplift this submodule in vscode_erlang to get back the updates.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/erlang-ls/grammar/issues/1#issuecomment-870548171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHLD7HW2Q7YYKHGWQ3Z2LTVG2WPANCNFSM4XFAZVJA .

[robertoaloi]

Hi, even if the idea behind https://github.com/pgourlain/vscode_erlang/issues/181 was to port the vscode_erlang grammar improvements to the shared repo, I don't think that was ever done. vscode_erlang simply switched to this repo, so it's very likely that some improvements got lost in the process.

It should be possible to diff the grammar that got removed [here| https://github.com/pgourlain/vscode_erlang/commit/27cbea3dde1b96ab399c1e6903f3d9f242293bc9] and port eventual improvements to this shared repo (and bump it in both pgourlain/vscode_erlang and erlang-ls/vscode).

[KornelH]

Current Erlang.plist has 2 small differences compared to the erlang.tmLanguage in pgourlain/vscode_erlang commit 6975d9a that I used to add syntax updates for OTP 23 and fix some highlighting glitches like spec lines, record definitions, etc. (see commits 921bb3e and db9ef8b.)

When my time will allow I will merge those updates here (unless somebody else is more eager to do it ;)). I still know about some additional issues in syntax highlighting but I'm not a pro of TextMate language files and Oniguruma regular expressions and unfortunately I couldn't fix those.

[KornelH]

If I'm right this issue was fixed by pull request #4.