erlang / otp

Erlang/OTP
http://erlang.org
Apache License 2.0
11.15k stars 2.92k forks source link

Fix cpool_delete() #8627

Open rickard-green opened 2 days ago

rickard-green commented 2 days ago

When setting modification marker on the prev field of a carrier to delete from a pool, we back off and wait for the content of the field to receive expected value if it did not have that from the beginning. Due to a copy-paste bug; when this happened, we waited on a completely different memory location which caused the scheduler thread doing this to get stuck forever. This is obviously a very rare scenario, since this bug has been present for 11 years without being reported.

github-actions[bot] commented 2 days ago

CT Test Results

    3 files    141 suites   49m 1s :stopwatch: 1 589 tests 1 539 :white_check_mark: 49 :zzz: 1 :x: 2 290 runs  2 220 :white_check_mark: 69 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit e176896d.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot