search

erlang / rebar3

Erlang build tool that makes it easy to compile and test Erlang applications and releases.
http://www.rebar3.org
Apache License 2.0
1.71k stars 517 forks source link

rebar3 use of tidy deps plugin #1974

Closed stuart-thackray closed 5 years ago

stuart-thackray commented 5 years ago

With https://github.com/erlang/rebar3/commit/56b7d88975aa8da6446857cfd92de0825024bf63 in rebar_git_resource it removed download/3 export and replaced it with download/4; this has stopped the tidy deps from working.

As far as I can see there is no reason that download/3 can't be exported aswell.

rebar3_tidy_deps is a documented plugin (https://www.rebar3.org/docs/custom-dep-resources).

If download/3 can be exported; I can send a PR for the git reasource and any other applicable one. Otherwise let me know if the tidy deps needs to be updated and I will do a PR there rather.

tsloughter commented 5 years ago

Ah yes, a PR for adding download/3 back would be great.