erlang / rebar3

Erlang build tool that makes it easy to compile and test Erlang applications and releases.
http://www.rebar3.org
Apache License 2.0
1.7k stars 518 forks source link

Changes made to sys.config.src are not taking effect #2775

Open helloyan opened 1 year ago

helloyan commented 1 year ago

Enviroment: rebar 3.20.0 on Erlang/OTP 24 Erts 12.3.2.1 OS Name: Microsoft Windows 10 专业版 OS Version: 10.0.19042 N/A Build 19042

When I use the config/sys.config.src file and the release command, I can see the sys.config.src file in rel/appname/release/x.x.x/sys.config.src, but the configuration changes don't take effect.

sys.config.src [{kernel, [{logger, [{handler, default, undefined}]}]}].

The configuration changes take effect under CentOS 7, and the sys.config file is generated after running '_build/***/bin/appname console', but the file isn't generated on Windows systems.

ferd commented 1 year ago

I'm pretty sure this could be because nobody using windows has ever submitted a pull request to add that support.

https://github.com/erlware/relx/commit/ee477fb31ad9a7603aaea8922aaa9ecd3712ee2d shows the commit editing the regular extended script to support it, but not the windows one, and at a glance, neither of the windows script files refer to it: https://github.com/erlware/relx/blob/fc931c42a4f18a9bc20064fb1d54c386463b9596/priv/templates/extended_bin_windows_ps#L57 or https://github.com/erlware/relx/blob/fc931c42a4f18a9bc20064fb1d54c386463b9596/priv/templates/extended_bin_windows#L174