Add config file support, refactorings

[deadtrickster]

Hi,

also features:

• optional verbose indent error/stacktrace;
• indent options depend on indentW.

Today I spent some time integrating erlang_ls -i with my emacs: https://github.com/deadtrickster/erlang-format.

How to ask indent to remove traling whitespace?

[deadtrickster]

Oh, there is no tests. for the new features. Please let me know what's the best way to test config file.

[coveralls]

Coverage decreased (-0.3%) to 63.461% when pulling 9fa758edb6470e2472c1ad531cdb540c06be38bb on deadtrickster:indent/config into f84090f127194cbee464dd105eb5e670e1509ed5 on erlang:master.

[vladdu]

This looks good, thank you Ilya! There are a few minor points:

• description for the 'config' option doesn't match
• I am not sure if the comments for indentation preferences (and thus the use of IndentW) are entirely correct, I think nobody tested with other values than 4. I'm not sure if other values make much sense. Did you try any other value to see if the result looks alright?
• please document the config file's format. I think the right place would be in the README file, when there will be a description of the CLI usage there. For the time being, I think just add it there as a side note.

I don't think there is support for removing the trailing whitespace. Usually, editors have that kind of functionality in a generic way, but I suppose it wouldn't hurt to do it ourselves anyway. Please open a ticket for that.

[deadtrickster]

Did you try any other value to see if the result looks alright?

yep. I use indentW=2 in my own projects, the only thing I noticed (so far) is difference for 'before_arrow'.

But, since config added that can override all paramters I would live with what we have and expect people to patch this naturally. I assume for indentW=4 it behaves as erlang-mode anyway.

[vladdu]

It may be that 'before_arrow' should be 2, instead of IndentW div 2?

[deadtrickster]

dunno, now I think it makes sense as it visually distinguishes between function body and when

[vladdu]

Ok, no problem. Looks good now, if there are problems later we can change those. It's great that you did the emacs integration, we can get feedback from there too.

[vladdu]

Oh, yes, testing the config file... I guess only getPrefs should be tested, because maybe_load_config is just a wrapper around file:consult. We are interested in checking that changing IndentW results in changed indentation options (only checking a couple is enough).

[deadtrickster]

added a test

[vladdu]

Thank you very much!