search

erlangbureau / jamdb_oracle

Oracle Database driver for Erlang
MIT License
106 stars 48 forks source link

Warning with ecto_sql 3.9.x #122

Closed winks closed 2 years ago

winks commented 2 years ago

Hi, I just updated to 0.5.2 (with Ecto 3.9.1) and there's a warning:

warning: function dump_cmd/3 required by behaviour Ecto.Adapter.Structure is not implemented (in module Ecto.Adapters.Jamdb.Oracle)
  lib/jamdb_oracle_ecto.ex:1: Ecto.Adapters.Jamdb.Oracle (module)

This is actually mentioned in the changelog: https://github.com/elixir-ecto/ecto_sql/blob/master/CHANGELOG.md#v390-2022-09-27 but of course that was released after 0.5.2

I didn't look deeper into the code, just thought I'd mention it.

vstavskyi commented 2 years ago

Unused behaviours can be removed. commit